Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c #31153

Merged
merged 2 commits into from Feb 7, 2022
Merged

bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c #31153

merged 2 commits into from Feb 7, 2022

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 6, 2022 •
edited by miss-islington

va_end() must be called before returning.

https://bugs.python.org/issue40479

Automerge-Triggered-By: GH:tiran

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Feb 6, 2022

This is a skip news PR.

The va_start() calls could be moved next to PyErr_FormatV().

tiran
tiran approved these changes Feb 6, 2022
View changes
Copy link
Member

@tiran tiran left a comment

good catch!

tiran
tiran requested changes Feb 6, 2022
View changes
Copy link
Member

@tiran tiran left a comment

Please add a news entry. The problematic code is in releases 3.9.10 and 3.10.2.

@bedevere-bot
Copy link

bedevere-bot commented Feb 6, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Feb 7, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Feb 7, 2022

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran Feb 7, 2022
tiran
tiran approved these changes Feb 7, 2022
View changes
Copy link
Member

@tiran tiran left a comment

Thank you!

@tiran tiran added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Feb 7, 2022
@miss-islington miss-islington merged commit 59e004a into python:main Feb 7, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Feb 7, 2022

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2022
@ZackerySpytz @miss-islington
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
7f643ec 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 7, 2022

GH-31183 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 7, 2022
@ZackerySpytz @miss-islington
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
4749a15 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 7, 2022

GH-31184 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 7, 2022
@miss-islington @ZackerySpytz
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (GH-31153)
3ceff99 
va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Feb 7, 2022
@miss-islington @ZackerySpytz
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (GH-31153)
0892a0e 
va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@tiran tiran mentioned this pull request May 9, 2022
Open
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @ZackerySpytz @hello-adam
bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (pythonGH…
2dd2e18 
…-31153)

va_end() must be called before returning.
(cherry picked from commit 59e004a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZackerySpytz @bedevere-bot @miss-islington @tiran @the-knights-who-say-ni