Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32528: Document the change in inheritance of asyncio.CancelledError #21474

Merged
merged 1 commit into from Jul 14, 2020
Merged

bpo-32528: Document the change in inheritance of asyncio.CancelledError #21474

merged 1 commit into from Jul 14, 2020

Conversation

JustAnotherArchivist
Copy link
Contributor

@JustAnotherArchivist JustAnotherArchivist commented Jul 14, 2020 •
edited by miss-islington

https://bugs.python.org/issue32528#msg373510

bpo-32528/#13528 changed asyncio.CancelledError such that it no longer inherits from concurrent.futures.CancelledError. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

https://bugs.python.org/issue32528

Automerge-Triggered-By: @1st1

@bedevere-bot bedevere-bot added docs awaiting review labels Jul 14, 2020
1st1
1st1 approved these changes Jul 14, 2020
View changes
@1st1 1st1 added needs backport to 3.8 needs backport to 3.9 🤖 automerge labels Jul 14, 2020
gvanrossum
gvanrossum approved these changes Jul 14, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Thanks!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 14, 2020

@JustAnotherArchivist: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 2a51818 into python:master Jul 14, 2020
10 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 14, 2020

Thanks @JustAnotherArchivist for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2020
@JustAnotherArchivist @miss-islington
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
99475ea 
…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 14, 2020

GH-21476 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2020
@JustAnotherArchivist @miss-islington
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
db1d1b1 
…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
miss-islington added a commit that referenced this issue Jul 19, 2020
@miss-islington @JustAnotherArchivist
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
700cb66 
…or (GH-21474)

GH-msg373510

[bpo-32528]()/GH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
J-Arun-Mani pushed a commit to J-Arun-Mani/cpython that referenced this issue Jul 21, 2020
@JustAnotherArchivist @J-Arun-Mani
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
3faa4ee 
…or (pythonGH-21474)

#msg373510

[bpo-32528]()/python#13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 24, 2020

Thanks @JustAnotherArchivist for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 24, 2020
@JustAnotherArchivist @miss-islington
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
2f1940e 
…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 24, 2020

GH-21606 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this issue Jul 24, 2020
@miss-islington @JustAnotherArchivist
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
ba07d4a 
…or (GH-21474)

GH-msg373510

[bpo-32528]()/GH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Aug 4, 2020
@JustAnotherArchivist @shihai1991
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
b3aef83 
…or (pythonGH-21474)

#msg373510

[bpo-32528]()/python#13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Aug 20, 2020
@JustAnotherArchivist @shihai1991
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
001bb55 
…or (pythonGH-21474)

#msg373510

[bpo-32528]()/python#13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
xzy3 pushed a commit to xzy3/cpython that referenced this issue Oct 18, 2020
@JustAnotherArchivist
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
86be7a4 
…or (pythonGH-21474)

#msg373510

[bpo-32528]()/python#13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@JustAnotherArchivist @chrisburr
bpo-32528: Document the change in inheritance of asyncio.CancelledErr…
cd22bd3 
…or (pythonGH-21474)

#msg373510

[bpo-32528]()/python#13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed docs 🤖 automerge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JustAnotherArchivist @miss-islington @bedevere-bot @1st1 @gvanrossum @tirkarthi @the-knights-who-say-ni