Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474) #21476

Merged
merged 1 commit into from Jul 19, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 14, 2020

GH-msg373510

[bpo-32528]()/GH-13528 changed asyncio.CancelledError such that it no longer inherits from concurrent.futures.CancelledError. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist JustAnotherArchivist@users.noreply.github.com

https://bugs.python.org/issue32528

…or (pythonGH-21474)

GH-msg373510

[bpo-32528]()/pythonGH-13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document.

Automerge-Triggered-By: @1st1
(cherry picked from commit 2a51818)

Co-authored-by: JustAnotherArchivist <JustAnotherArchivist@users.noreply.github.com>
@miss-islington
Copy link
Contributor Author

miss-islington commented Jul 14, 2020

@JustAnotherArchivist: Status check is done, and it's a success .

eamanu
eamanu approved these changes Jul 17, 2020
Copy link
Member

@tirkarthi tirkarthi left a comment

LGTM. cc: @1st1 as it's a backport of the change previously automerged.

@miss-islington miss-islington merged commit 700cb66 into python:3.8 Jul 19, 2020
5 checks passed
@miss-islington miss-islington deleted the backport-2a51818-3.8 branch Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants