Update the authors script to generate the content of authors.md #36867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
reviewed
Feb 19, 2020
scripts/authors.ts
Outdated
| @@ -162,6 +165,16 @@ namespace Commands { | |||
| console.log("====================="); | |||
| deduplicate(unknownAuthors).sort(sortAuthors).forEach(log); | |||
| } | |||
|
|
|||
|
|
|||
| const allAuthors = deduplicate([...knownAuthors, ...unknownAuthors].map(a => a.split("<")[0])).sort(sortAuthors); | |||
There was a problem hiding this comment.
If you split by < and pipe to a file, does that mean you'll end up with trailing whitespace on certain lines?
There was a problem hiding this comment.
I'll trim to make sure anyway, though this isn't pipeable because it's part of a longer list command
|
This actually greened on Travis, so I'm merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This file is now entirely auto-generated. I made a quick script with all the old names in to verify they are all in there from the file before I automated it afterwards.
Personally, I'm open to killing the mailmap file and making this script generate this file entirely - but for now this is good enough, we'll see where that conversation goes in teams.