Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91498: Add TCP_CONNECTION_INFO constant to socket module. #91510

Closed
wants to merge 1 commit into from
Closed

gh-91498: Add TCP_CONNECTION_INFO constant to socket module. #91510

wants to merge 1 commit into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 13, 2022

closes: gh-91498

@corona10 corona10 requested a review from methane Apr 13, 2022
@corona10
Copy link
Member Author

@corona10 corona10 commented Apr 13, 2022

@methane I notice that constants like TCP_INFO and TCP_CONNECTION_INFO are used for packet analysis with struct.unpack :)

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 14, 2022

We already have #69256 open for this. Would you mind reviewing and merging that instead?

@corona10
Copy link
Member Author

@corona10 corona10 commented Apr 14, 2022

@JelleZijlstra Oh I didn't know that, GitHub issue should be linked likewise what we did for bpo :(

@corona10 corona10 closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket: Add TCP_CONNECTION_INFO
3 participants
@corona10 @JelleZijlstra @bedevere-bot