[HttpFoundation] Test invalid cookie regeneration #46207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was trying to audit the code and couldn't find any code coverage for this so wrote something down to help me step through it. Figured it might be useful for a little extra code coverage and protection against regressions. |
Asserts that validateId logic in AbstractSesssionHandler correctly protects against session fixation attempts by regenerating the session id.
neclimdul
force-pushed
the
session-fixation-test
branch
from
eaf2ef2 to
70c96f8
Compare
fabpot
approved these changes
Jul 21, 2022
|
Thank you @neclimdul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts that validateId logic in AbstractSesssionHandler correctly protects against session fixation attempts by regenerating the session id.
Just some free test coverage. No fixes or features or any of that.