Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces an old-style unbind with a pair of pragmas, and fixes a join-order to put the delta first.
The optimiser would put the visible loop-invariant parts first, and then proceed to early-join the
NOT ..#prev
to ruin the loop-invariant-ness, which caused each iteration to mostly re-evaluate the same thing. This predicate generally isn't very big, so it wasn't that expensive in wall clock time, but was highlighted by the join-order-badness metric in the nightly dca, so definitely worth fixing.Before:
After: