-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-9305: Remove east/west references from datetime #31697
Conversation
I understand what this PR is trying to do but think it makes users worse off. For the most part, people understand the UTC offset sign conventions in terms of being east or west of the prime meridian. While this isn't 100% true, it is a good approximation and mental model. It would be better to leave the East/West positive/negative references in place and just add a note somewhere in the docs explaining the exceptions to the rule. |
Hmm, for the docs, what about instead adding an east/west note on the 'if the time being compared is east of UTC, and keeping the east/west removal under the Regarding the docstrings, I'm pretty indifferent and would be fine with keeping east/west as-is if it reads better there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test_datetime produces:
Ran 960 tests in 10.108s
OK (skipped=28)
Also, the Docs for datetime is readable and concise.
I'm going to mark this as closed, but another core dev can reopen if they feel strongly about it. AFAICT no reported user problem is being solved here. IMO it is a nitpick that while technically correct will make the docs less usable. People do mentally time offsets with east and west. That is a useful first approximation. To misquote Kronecker, "god created the east/west timezone offsets, the rest of the funky timezone lines are the work of man." ;-) |
https://bugs.python.org/issue9305