gh-91880: add try/except around signal.signal
#91881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Apr 24, 2022
Lib/asyncio/runners.py
Outdated
| try: | ||
| signal.signal(signal.SIGINT, sigint_handler) | ||
| except ValueError: | ||
| pass |
There was a problem hiding this comment.
I'd be more comfortable if at this point you set sigint_handler = None. It is not strictly required, but that's more or less an accident of the implementation; setting it to None is a clear signal that no restoration is required at the end (used also below).
In addition, I'd like to see a comment explaining under which circumstances we expect ValueError and what it means (since it wasn't clear to the original author, nor to me, why the tests for applicability of signal handling is not 100% effective).
There was a problem hiding this comment.
Thanks, I've pushed a commit to set to None with a comment as requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As suggested in #32105 (comment) by @gvanrossum, add a
try/exceptaround use ofsignal.signalto protect against possible exceptions.