Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89301: Fix regression with bound values in traced SQLite statements #92053

Merged
merged 3 commits into from May 2, 2022
Merged

gh-89301: Fix regression with bound values in traced SQLite statements #92053

merged 3 commits into from May 2, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 29, 2022 •
edited

Resolves gh-89301

@erlend-aasland erlend-aasland added needs backport to 3.10 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 29, 2022
@bedevere-bot
Copy link

bedevere-bot commented Apr 29, 2022

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ab35f4b 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@erlend-aasland
Make exception string greppable
4e9ef10
@erlend-aasland
Simplify test
e58797c 
SQLite seems to have slightly inconsisten behaviour when it comes to
enforcing limits. It might have something to do with the SQLite compile
time options, or it may be a bug. Simplifying the test seems to work
in different environments.
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2022
@bedevere-bot
Copy link

bedevere-bot commented May 2, 2022

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e58797c 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2022
@erlend-aasland erlend-aasland marked this pull request as ready for review May 2, 2022
@erlend-aasland erlend-aasland requested review from JelleZijlstra and removed request for berkerpeksag May 2, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2022

FYI, AMD64 Fedora Stable Refleaks PR failed test_embed, so that looks unrelated.

@erlend-aasland erlend-aasland requested a review from berkerpeksag May 2, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2022 •
edited

FTR, this is pretty much the same as GH-28240, but with better tests and a more accurate NEWS entry.

@JelleZijlstra JelleZijlstra merged commit 721aa96 into python:main May 2, 2022
84 of 85 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 721aa96540bb96700f8c4bab0b4095b43491dca1 3.10

@erlend-aasland erlend-aasland deleted the sqlite-fix-trace branch May 2, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2022

Thanks, I'll fix the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@berkerpeksag berkerpeksag

Assignees

@JelleZijlstra JelleZijlstra

Labels
needs backport to 3.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3 regression: bound values are not expanded in traced statements
4 participants
@erlend-aasland @bedevere-bot @miss-islington @JelleZijlstra