Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-79097: Add support for aggregate window functions in sqlite3 #20903

Merged
merged 57 commits into from Apr 12, 2022
Merged

gh-79097: Add support for aggregate window functions in sqlite3 #20903

merged 57 commits into from Apr 12, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 15, 2020 •
edited

Fixes #79097

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Nov 6, 2020

Rebased onto master and upgraded with Py_NewRef and intermingled declarations.

@erlend-aasland erlend-aasland marked this pull request as draft Nov 17, 2020
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Nov 17, 2020

On hold until #23341 is merged

@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from f39fc9f to a36a1a5 Compare Dec 28, 2020
@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 10 times, most recently from 9c27690 to b91947d Compare Mar 10, 2021
@erlend-aasland erlend-aasland marked this pull request as ready for review Mar 10, 2021
@erlend-aasland erlend-aasland mentioned this pull request Mar 10, 2021
Draft
@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from 5f17f41 to f1459ed Compare Apr 18, 2021
@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from 799bcf6 to 3f052a6 Compare Apr 23, 2021
@erlend-aasland
Add support for sqlite3 aggregate window functions
bbef5a4 
See https://docs.python.org/3/library/exceptions.html#NotImplementedError:
It should not be used to indicate that an operator or method is not
meant to be supported at all – in that case either leave the operator /
method undefined or, if a subclass, set it to None.
@erlend-aasland
Add NEWS entry
93bfb30
@erlend-aasland
Add What's New
7dfeb13
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Apr 23, 2021 •
edited

@berkerpeksag Any chance of getting this in before the feature freeze early in the 3.11 dev phase?

@erlend-aasland erlend-aasland changed the title bpo-34916: Add support for aggregate window functions in sqlite3 bpo-79097: Add support for aggregate window functions in sqlite3 Apr 10, 2022
@erlend-aasland erlend-aasland changed the title bpo-79097: Add support for aggregate window functions in sqlite3 gh-79097: Add support for aggregate window functions in sqlite3 Apr 10, 2022
@erlend-aasland erlend-aasland marked this pull request as ready for review Apr 10, 2022
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots label Apr 10, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 10, 2022

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 10, 2022
@erlend-aasland erlend-aasland added 🔨 test-with-buildbots extension-modules labels Apr 10, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 10, 2022

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 10, 2022
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Apr 11, 2022

@JelleZijlstra, would you like to review this?

FYI, the two buildbot failures look unrelated.

@JelleZijlstra JelleZijlstra self-requested a review Apr 11, 2022
JelleZijlstra
JelleZijlstra reviewed Apr 11, 2022
View changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Looks good, just one requested improvement in the tests.

Let me know if there's other changes you'd like to get in in time for 3.11.

Lib/test/test_sqlite3/test_userfunctions.py Show resolved Hide resolved
@JelleZijlstra JelleZijlstra self-assigned this Apr 11, 2022
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Apr 11, 2022

Let me know if there's other changes you'd like to get in in time for 3.11.

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 11, 2022

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

Sounds good, ping me when you're ready.

@JelleZijlstra JelleZijlstra merged commit 9ebcece into python:main Apr 12, 2022
13 checks passed
@BigStone BigStone mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303

@JelleZijlstra JelleZijlstra

@berkerpeksag berkerpeksag

Assignees

@JelleZijlstra JelleZijlstra

Labels
CLA signed extension-modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add create_window_function() to sqlite3.Connection
5 participants
@erlend-aasland @bedevere-bot @JelleZijlstra @kumaraditya303 @the-knights-who-say-ni