Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Button on ListView should not pass click to listview when disabled #12370

Open
wants to merge 5 commits into
base: 5.0.0
Choose a base branch
from
Open

fix: Button on ListView should not pass click to listview when disabled #12370

wants to merge 5 commits into from

Conversation

l4nk4b3l
Copy link

@l4nk4b3l l4nk4b3l commented Oct 5, 2020

Issues Resolved

fixes #8763

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • [] Targets the correct branch
  • [] Tests are passing (or failures are unrelated)

@dnfadmin
Copy link

@dnfadmin dnfadmin commented Oct 5, 2020 •
edited

CLA assistant check
All CLA requirements met.

rmarinho
rmarinho requested changes Oct 14, 2020
View changes
Copy link
Member

@rmarinho rmarinho left a comment

Is it possible to add a UITest and a sample case so we can see what this is supposed to fix.

Thanks

@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 2, 2020
@samhouts samhouts moved this from In Progress to In Review in vNext+1 (5.0.0) Nov 3, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts removed this from In progress in v5.0.1 Nov 5, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Progress in vNext+1 (5.0.0) Nov 5, 2020
jsuarezruiz
jsuarezruiz requested changes Dec 2, 2020
View changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

@l4nk4b3l Could you include a sample (and maybe a UITest) where validate the issue and the fix?. Let me know if you need help with something.

v5.0.1 automation moved this from In progress to Review in progress Dec 2, 2020
@l4nk4b3l
Copy link
Author

@l4nk4b3l l4nk4b3l commented Feb 19, 2021 •
edited

@l4nk4b3l Could you include a sample (and maybe a UITest) where validate the issue and the fix?. Let me know if you need help with something.

@jsuarezruiz
Is the a guide on how to write a uitest ?
Are there sample tests ?
I don't know where to start.

@jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Sep 22, 2021

The sample should be added here: https://github.com/xamarin/Xamarin.Forms/tree/5.0.0/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared
About UITest: https://docs.microsoft.com/en-us/appcenter/test-cloud/frameworks/uitest/cheatsheet
Can find many samples in the gallery, but if need anything or you feel blocked let me know and I can create it and share with you.

@l4nk4b3l
Copy link
Author

@l4nk4b3l l4nk4b3l commented Oct 15, 2021

Thank you!
The additional information was enough so i could add a uitest to proof this issue has been fixed.

@l4nk4b3l l4nk4b3l requested a review from jsuarezruiz Jan 5, 2022
@l4nk4b3l l4nk4b3l requested a review from rmarinho Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz

@rmarinho rmarinho

Assignees
No one assigned
Labels
a/listview good first issue hacktoberfest 🍻 hacktoberfest-accepted p/iOS 🍎 t/bug 🐛
Projects
v5.0.1
Review in progress
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[Bug] ContextAction Button on ListView Cell on iOS passes Tap to Cell when CanExecute is false
5 participants
@l4nk4b3l @dnfadmin @jsuarezruiz @rmarinho @samhouts