Skip to content

bpo-46787: Fix ProcessPoolExecutor exception memory leak #31408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2022
Merged

bpo-46787: Fix ProcessPoolExecutor exception memory leak #31408

merged 2 commits into from
May 2, 2022

Conversation

themylogin
Copy link
Contributor

@themylogin themylogin commented Feb 18, 2022 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@themylogin

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@themylogin themylogin changed the title bpo-NNNN: Fix ProcessPoolExecutor exception memory leak bpo-46787: Fix ProcessPoolExecutor exception memory leak Feb 18, 2022
JelleZijlstra
JelleZijlstra reviewed Feb 19, 2022
View reviewed changes
@themylogin
bpo-46787: Fix ProcessPoolExecutor exception memory leak (pythonGH-…
a7fa191 
…31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 2, 2022
@JelleZijlstra JelleZijlstra merged commit 9c204b1 into python:main May 2, 2022
@miss-islington
Copy link
Contributor

Thanks @themylogin for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92187 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 2, 2022
@bedevere-bot
Copy link

GH-92188 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@themylogin @miss-islington
bpo-46787: Fix ProcessPoolExecutor exception memory leak (pythonGH-…
0890e92 
…31408) (pythonGH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <themylogin@gmail.com>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @themylogin
bpo-46787: Fix ProcessPoolExecutor exception memory leak (GH-31408) (…
c467812 
…GH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <themylogin@gmail.com>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @themylogin
bpo-46787: Fix ProcessPoolExecutor exception memory leak (GH-31408) (…
51b885a 
…GH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <themylogin@gmail.com>
@AlexWaygood AlexWaygood mentioned this pull request May 3, 2022
Closed
@themylogin themylogin mannequin mentioned this pull request Apr 10, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @themylogin @hello-adam
bpo-46787: Fix ProcessPoolExecutor exception memory leak (pythonGH-…
9d6752a 
…31408) (pythonGH-31408)

Do not store `ProcessPoolExecutor` work item exception traceback that prevents
exception frame locals from being garbage collected.
(cherry picked from commit 9c204b1)

Co-authored-by: themylogin <themylogin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@themylogin @the-knights-who-say-ni @miss-islington @bedevere-bot @JelleZijlstra