Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire: fix "Arduino way" I2C scan #214

Merged
merged 1 commit into from May 17, 2021
Merged

Wire: fix "Arduino way" I2C scan #214

merged 1 commit into from May 17, 2021

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented May 4, 2021

@sievers
Completely fixes #212

Portenta is a bit peculiar and responds correctly to the zero bytes write() but not to the read(); to be investigated.

@facchinm facchinm requested a review from pennam May 4, 2021
@github-actions
Copy link

@github-actions github-actions bot commented May 4, 2021

Memory usage change @ da21f0e

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/RPC/examples/RPC_m4
flash		 % libraries/RPC/examples/RPC_m4
RAM for global variables		 % libraries/RPC/examples/SerialPassthrough_RPC
flash		 % libraries/RPC/examples/SerialPassthrough_RPC
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 % libraries/Portenta_Camera/examples/CameraCaptureRawBytes
flash		 % libraries/Portenta_Camera/examples/CameraCaptureRawBytes
RAM for global variables		 % libraries/Portenta_Camera/examples/CameraMotionDetect
flash		 % libraries/Portenta_Camera/examples/CameraMotionDetect
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
flash		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
RAM for global variables		 % libraries/WiFi/examples/WiFiWebClient
flash		 % libraries/WiFi/examples/WiFiWebClient
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/AP_SimpleWebServer
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/AP_SimpleWebServer
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectNoEncryption
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectNoEncryption
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWEP
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWEP
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA2Enterprise
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA2Enterprise
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworks
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworks
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworksAdvanced
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworksAdvanced
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/SimpleWebServerWiFi
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/SimpleWebServerWiFi
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/Tools/CheckFirmwareVersion
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/Tools/CheckFirmwareVersion
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/Tools/FirmwareUpdater
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/Tools/FirmwareUpdater
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/Tools/SerialNINAPassthrough
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/Tools/SerialNINAPassthrough
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiChatServer
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiChatServer
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiPing
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiPing
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiSSLClient
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiSSLClient
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiStorage
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiStorage
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpNtpClient
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpNtpClient
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpSendReceiveString
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpSendReceiveString
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClient
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClient
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClientRepeating
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClientRepeating
RAM for global variables		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebServer
flash		 % /home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebServer
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/RPC/examples/RPC_m4<br>flash,%,libraries/RPC/examples/RPC_m4<br>RAM for global variables,%,libraries/RPC/examples/SerialPassthrough_RPC<br>flash,%,libraries/RPC/examples/SerialPassthrough_RPC<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%,libraries/Portenta_Camera/examples/CameraCaptureRawBytes<br>flash,%,libraries/Portenta_Camera/examples/CameraCaptureRawBytes<br>RAM for global variables,%,libraries/Portenta_Camera/examples/CameraMotionDetect<br>flash,%,libraries/Portenta_Camera/examples/CameraMotionDetect<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>flash,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>RAM for global variables,%,libraries/WiFi/examples/WiFiWebClient<br>flash,%,libraries/WiFi/examples/WiFiWebClient<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/AP_SimpleWebServer<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/AP_SimpleWebServer<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectNoEncryption<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectNoEncryption<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWEP<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWEP<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA2Enterprise<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ConnectWithWPA2Enterprise<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworks<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworks<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworksAdvanced<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/ScanNetworksAdvanced<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/SimpleWebServerWiFi<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/SimpleWebServerWiFi<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/Tools/CheckFirmwareVersion<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/Tools/CheckFirmwareVersion<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/Tools/FirmwareUpdater<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/Tools/FirmwareUpdater<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/Tools/SerialNINAPassthrough<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/Tools/SerialNINAPassthrough<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiChatServer<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiChatServer<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiPing<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiPing<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiSSLClient<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiSSLClient<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiStorage<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiStorage<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpNtpClient<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpNtpClient<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpSendReceiveString<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClient<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClient<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClientRepeating<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebClientRepeating<br>RAM for global variables,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebServer<br>flash,%,/home/runner/Arduino/libraries/WiFiNINA/examples/WiFiWebServer<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,,,,
arduino:mbed:nanorp2040connect,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

pennam
pennam reviewed May 10, 2021
View changes
Copy link
Contributor

@pennam pennam left a comment

Tested on 3a2a248 with 2 connected devices (LM75B and AT24CXX) read works fine also on Portenta. I think we could remove conditional compilation directives.

@fsievers
Copy link

@fsievers fsievers commented May 13, 2021

I checked the changes on my Pi Pico and can confirm, that the I2C scan is now working as expected.

@facchinm facchinm merged commit dee2eb0 into master May 17, 2021
9 checks passed
@facchinm facchinm deleted the fix_i2c_scan branch Jun 23, 2021
@ratio-x ratio-x mentioned this pull request Mar 2, 2022
Open
ratio-x added a commit to ratio-x/ArduinoCore-mbed that referenced this issue Mar 2, 2022
@ratio-x
Wire.endTransmission() uses write() to enable I2C scanning
09209bc 
Revert PR arduino#214, as discussed in issue 414.
@ratio-x ratio-x mentioned this pull request Mar 2, 2022
Open
@ratio-x ratio-x mentioned this pull request Mar 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to get I2C working on Raspberry Pi Pico
3 participants
@facchinm @fsievers @pennam