Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: warn if the size of a binary increases by more than X % #3404

Open
sylvestre opened this issue Apr 14, 2022 · 0 comments
Open

CI: warn if the size of a binary increases by more than X % #3404

sylvestre opened this issue Apr 14, 2022 · 0 comments
Labels
good first issue

Comments

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Apr 14, 2022

Currently, we only look at build size after the PR ( https://github.com/uutils/coreutils-tracking#binary-size-evolution )

We should monitor this in the CI. For this, we should update:
https://github.com/uutils/coreutils/blob/main/.github/workflows/CICD.yml#L529-L536=

And keep track of the individual size of the binary ( like https://github.com/uutils/coreutils-tracking/blob/main/gnu-full-result.json )
and compare if this is significantly increase (ex: > 5%) and trigger a warning.

@sylvestre sylvestre added the good first issue label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
Projects
None yet
Development

No branches or pull requests

1 participant