Skip to content

[HttpKernel] Adding _renderer attribute like _format in request to make Fragment (SubRequest) detectable. #46151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kuldippujara
Copy link

symfony/webpack-encore-bundle#115 (comment)

Q A
Branch? 6.1 for features / 4.4, 5.4 or 6.0 for bug fixes
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

I have attached a _renderer attribute when subrequest render as inline request by fragment as want to solve the issue which broken by symfony/webpack-encore-bundle#115 (comment) PR which is a helper for rendering multiple files or mails and want to reset the assets but its breaking the render(controller(..)) and any other embed feature due to that.

This is my first PR. sorry if its not good enough.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title To fix the following issue, I have done this changes : [HttpKernel] To fix the following issue, I have done this changes : Apr 24, 2022
@stof
Copy link
Member

stof commented Apr 27, 2022

Please provide a proper title for your PR.

@kuldippujara kuldippujara changed the title [HttpKernel] To fix the following issue, I have done this changes : [HttpKernel] Adding _renderer attribute like _format in request to make Fragment (SubRequest) detectable. Apr 27, 2022
@kuldippujara
Copy link
Author

Hi @stof,
I have updated title of the PR and also updated the phpunit test case to match with new functionality.

there is one failure but not sure how to fix can you help me with that ?

There was 1 error:
1) Symfony\Component\VarDumper\Tests\Dumper\ServerDumperTest::testDump
Symfony\Component\Process\Exception\ProcessTimedOutException: The process "c:\php\php.exe" exceeded the timeout of 19 seconds.
C:\projects\symfony\src\Symfony\Component\Process\Process.php:1152
C:\projects\symfony\src\Symfony\Component\Process\Process.php:423
C:\projects\symfony\src\Symfony\Component\VarDumper\Tests\Dumper\ServerDumperTest.php:69
ERRORS!
Tests: 331, Assertions: 427, Errors: 1, Skipped: 23.

Thanks

@fabpot fabpot modified the milestones: 6.1, 6.2 May 8, 2022
@fabpot
Copy link
Member

fabpot commented Jul 24, 2022

Can you explain how you're going to use this feature?

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.3 Nov 5, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@fabpot
Copy link
Member

fabpot commented Oct 6, 2023

Closing as there is no more activity.

@fabpot fabpot closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants