[DoctrineBridge] add generic service to reset object managers #46266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Deprecation
DoctrineBridge
Feature
RFC
carsonbot
changed the title
|
I'm not sure about this. The purpose of an ORM is also to deal with state-(re)synchronization on long running processes. Doing this by default would just break this. It's fine to me if the reset is opt-in. |
|
Fair enough, let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be off-base here but shouldn't the object manager's be reset between requests? Now that messenger supports resetting services, this could replace the
DoctrineClearEntityManagerWorkerSubscriber.Ran into an issue (zenstruck/messenger-test#43) where the em is cleared when processing messenger messages in tests. This was not desired and there is no way to disable. Another solution would be to make
DoctrineClearEntityManagerWorkerSubscriberconfigurable in doctrine-bundle (doctrine/DoctrineBundle#1043).I wanted to first check if there should be a more generic resetter.
TODO:
DoctrineClearEntityManagerWorkerSubscriber?