golangci / golangci-lint Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add forbidigo example that uses comments #2599
Conversation
Hey, thank you for opening your first Pull Request ! |
Can message be a bit more explanatory? ( in the example ). Cool feature, however, sad it removed proper error message. |
Yes the linters page is generated from the |
I'm not sure I understand, what proper error message does this feature remove?
Could do, although given that this is a contrived example, we'd have to invent some context. Maybe "don't use fmt, use some logger instead", but it feels weird to name any arbitrary logger in a golangci example. Please leave a suggestion if you have something specific in mind though |
Never mind about the error, i didn't notice you move regexp compilation into - '\.Debug\(\)\.(# Do not commit Debug code)?' # db Debug()
|
Done |
Will merge one get to the laptop. Thank you! |
Hey, @craigfurman — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
Add an example of a recently-added forbidigo feature, comments (ashanbrown/forbidigo#11).
Is the docs site (https://golangci-lint.run/usage/linters/#forbidigo) generated from this file?
The text was updated successfully, but these errors were encountered: