-
-
Notifications
You must be signed in to change notification settings - Fork 116
Comparing changes
Open a pull request
base repository: mvdan/gofumpt
base: v0.2.0
head repository: mvdan/gofumpt
compare: v0.2.1
- 11 commits
- 13 files changed
- 7 contributors
Commits on Nov 11, 2021
-
avoid using sign.Results.Closing when it's invalid
The position may be token.NoPos, an invalid position, if there's a single result parameter without parentheses. Using token.FileSet.Offset on token.NoPos+1 would panic: panic: invalid Pos value 1 (should be in [774665, 781950]) We didn't catch this because our tests always start with an empty token.FileSet, so most of our files start with the base position 1. A user ran into the bug when formatting many files at once. To ensure we catch these bugs quicker in the future, insert a dummy ten-byte file to every new FileSet we create. Finally, add a test, which reproduces the panic thanks to the dummy base file mentioned above. Fixes #166.
Configuration menu - View commit details
-
Copy full SHA for 9d037d4 - Browse repository at this point
Copy the full SHA 9d037d4View commit details
Commits on Nov 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7ca7e6c - Browse repository at this point
Copy the full SHA 7ca7e6cView commit details
Commits on Dec 5, 2021
-
format: don't group interface members of different kinds
For instance, don't group exported and unexported methods, nor methods with non-methods. Fixes #168.
Configuration menu - View commit details
-
Copy full SHA for 93927ca - Browse repository at this point
Copy the full SHA 93927caView commit details -
format: account for leading comments in composite literals
For an input such as: var _ = map[string]string{ /* joint comment */ "foo": "bar", } We would incorrectly join the comment with the first element: var _ = map[string]string{ /* joint comment */ "foo": "bar", } Just like in other parts of the codebase, consider the first comment's position if it exists. Fixes #170.
Configuration menu - View commit details
-
Copy full SHA for 872763c - Browse repository at this point
Copy the full SHA 872763cView commit details
Commits on Dec 12, 2021
-
add deprecated flags once again
This way, users calling -s or -r get a helpful message. The use of -s can still let the tool work, for now. Fixes #174.
Configuration menu - View commit details
-
Copy full SHA for cf88391 - Browse repository at this point
Copy the full SHA cf88391View commit details
Commits on Dec 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ea37f49 - Browse repository at this point
Copy the full SHA ea37f49View commit details
Commits on Dec 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 55d7eb4 - Browse repository at this point
Copy the full SHA 55d7eb4View commit details
Commits on Dec 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 53340e7 - Browse repository at this point
Copy the full SHA 53340e7View commit details -
format: treat
noinspection
as comment directiveUsed by some versions of GoLand and friends, https://www.jetbrains.com/help/go/disabling-and-enabling-inspections.html New versions use `//goland:noinspection` instead/additionally, but it doesn't hurt much to support the older (and still the only documented) one.
Configuration menu - View commit details
-
Copy full SHA for 4e57a27 - Browse repository at this point
Copy the full SHA 4e57a27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83c82b7 - Browse repository at this point
Copy the full SHA 83c82b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba9bdf9 - Browse repository at this point
Copy the full SHA ba9bdf9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.2.0...v0.2.1