feat: support TS in templates for @vue/vue3-jest #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vue 3.2.13 introduced the support of TS expressions in templates, with a new `isTs` option of the compiler. (See [the relevant commit](vuejs/core@0dc521b)) vue-loader and vite chose to enable this by default if the script uses TS: - [vue-loader](vuejs/vue-loader@7613534) - [vite](vitejs/vite@01fa2ab) This commit enables the same behavior in vue-jest: if the script is using TS, then the `isTs` option is passed to the compiler. TS developers won't have to worry about setting the options themselves, making it coherent with what vue-loader and vite do.
lmiller1990
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue 3.2.13 introduced the support of TS expressions in templates, with a new
isTsoption of the compiler.(See the relevant commit)
vue-loader and vite chose to enable this by default if the script uses TS:
This commit enables the same behavior in vue-jest: if the script is using TS, then the
isTsoption is passed to the compiler.TS developers won't have to worry about setting the options themselves, making it coherent with what vue-loader and vite do.