Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-38013: make async_generator_athrow object tolerant to throwing exceptions (GH-16070) #16232

Merged
merged 1 commit into from Sep 17, 2019
Merged

[3.7] bpo-38013: make async_generator_athrow object tolerant to throwing exceptions (GH-16070) #16232

merged 1 commit into from Sep 17, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 17, 2019 •
edited by bedevere-bot

Even when the helper is not started yet.

This behavior follows conventional generator one.
There is no reason for async_generator_athrow to handle gen.throw() differently.

https://bugs.python.org/issue38013
(cherry picked from commit c275312)

Co-authored-by: Andrew Svetlov andrew.svetlov@gmail.com

https://bugs.python.org/issue38013

@asvetlov @miss-islington
bpo-38013: make async_generator_athrow object tolerant to throwing ex…
94f485b 
…ceptions (pythonGH-16070)

Even when the helper is not started yet.

This behavior follows conventional generator one.
There is no reason for `async_generator_athrow` to handle `gen.throw()` differently.

https://bugs.python.org/issue38013
(cherry picked from commit c275312)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@miss-islington miss-islington requested a review from 1st1 as a code owner Sep 17, 2019
@bedevere-bot bedevere-bot mentioned this pull request Sep 17, 2019
Merged
@miss-islington
Copy link
Author

@miss-islington miss-islington commented Sep 17, 2019

@asvetlov: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit fc022f0 into python:3.7 Sep 17, 2019
5 checks passed
@miss-islington miss-islington deleted the backport-c275312-3.7 branch Sep 17, 2019
@miss-islington
Copy link
Author

@miss-islington miss-islington commented Sep 17, 2019

@asvetlov: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@1st1 1st1

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miss-islington @asvetlov @the-knights-who-say-ni @bedevere-bot