Fix cartesian hover toggle #5879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hover toggle button couldn't be enabled on cartesian plots because the later setup completely overwrote the initial allowed groups. So just make it add the cartesian buttons instead of replacing the groups completely.
|
@Sizurka Thanks very much for the PR. |
|
See here. Note that there is no hover toggle button on the mode bar, despite it being enabled in the layout. Other buttons (e.x. "togglespikelines") work correctly. |
|
Looking good to me. Please add a test somewhere here: plotly.js/test/jasmine/tests/modebar_test.js Line 158 in 042742d Also I appreciate if you draft Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The hover toggle button couldn't be enabled on cartesian plots because the later setup completely overwrote the initial allowed groups. So just make it add the cartesian buttons instead of replacing the groups completely.