Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn on noUncheckedIndexedAccess compiler flag #2341

Merged

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Jun 4, 2021

only changes were needed in tests, but it will make sure we don't rely on unsafe index accesses on objects and / or arrays in the future.

@vercel
Copy link

@vercel vercel bot commented Jun 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/EMqSZZoniger2Y21bBxDuAzKqz6d
Preview: https://react-query-git-fork-tkdodo-feature-no-unchecked-inde-ad2da6.vercel.app

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jun 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 388fb9a:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

use a const assertion over the bang operator so that we can safely access pages[0]
@TkDodo TkDodo merged commit 2b8d2af into tannerlinsley:master Jun 5, 2021
7 checks passed
@TkDodo TkDodo deleted the feature/no-unchecked-indexed-access branch Jun 5, 2021
@tannerlinsley
Copy link
Owner

@tannerlinsley tannerlinsley commented Jun 5, 2021

🎉 This PR is included in version 3.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants