Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(style): formatting #647

Merged
merged 2 commits into from Jun 28, 2020
Merged

(style): formatting #647

merged 2 commits into from Jun 28, 2020

Conversation

wolverineks
Copy link
Contributor

@wolverineks wolverineks commented Jun 28, 2020

adds more files to formatting,
other options:

  • add precommit hook to format
  • combine eslint + prettier

@wolverineks wolverineks changed the title Formatting (style): Formatting Jun 28, 2020
@wolverineks wolverineks changed the title (style): Formatting (style): formatting Jun 28, 2020
Copy link
Owner

@tannerlinsley tannerlinsley left a comment

This needs to be enabled && (documentIsVisible || refetchIntervalInBackground)

@wolverineks
Copy link
Contributor Author

@wolverineks wolverineks commented Jun 28, 2020

This needs to be enabled && (documentIsVisible || refetchIntervalInBackground)

prettier makes the claim that it doesnt change the ast of the code,
this is the way the code was going to execute anyway

if you want i can fix this in a different pr?
especially as this doesnt fail any tests

@tannerlinsley
Copy link
Owner

@tannerlinsley tannerlinsley commented Jun 28, 2020

Right, it didn’t change it here. It was just bad to start. :)

@wolverineks
Copy link
Contributor Author

@wolverineks wolverineks commented Jun 28, 2020

if you want to make the code suggestion ill accept it

@tannerlinsley
Copy link
Owner

@tannerlinsley tannerlinsley commented Jun 28, 2020

I already fixed in a separate Commit :)

@tannerlinsley tannerlinsley merged commit ac11bdc into tannerlinsley:master Jun 28, 2020
2 checks passed
@wolverineks wolverineks deleted the formatting branch Jun 28, 2020
@tannerlinsley
Copy link
Owner

@tannerlinsley tannerlinsley commented Jun 29, 2020

🎉 This PR is included in version 2.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants