Support ruby 3.0 #181
Support ruby 3.0 #181
Conversation
pariser
force-pushed
the
ruby3
branch
2 times, most recently
from
410faf6
to
53851d8
Compare
|
Note that this PR addresses #176 (namely wanting an update to this package that unblocks Ruby 3.0 support) I didn't go so far as to upgrade to rubocop 1.x as proposed in #178 , but I'd like to figure out a way to do that as a follow up in case the backwards compatibility of the rubocop 1.x upgrade poses problems for rubocop-airbnb gem users. |
| @@ -347,8 +347,9 @@ Style/FrozenStringLiteralComment: | |||
| Enabled: false | |||
There was a problem hiding this comment.
Can we enable this now we're not supporting 2.3? I remember it caused some problems when I updated the version a while ago but I wonder if it would be alright now
There was a problem hiding this comment.
@zpaines great question. Given the delay in requiring frozen string literals beyond the ruby 3 release (see some rubocop discussion on this topic), I'm less convinced that this is pressing now. There are potentially good reasons to want to enable frozen string literals, say for performance reasons, but I'm not sure where I land on enforcing this in the style guide now. Let's talk about this when we evaluate any new cops that have been added to rubocop since our last update and make a decision about this going forward for a 4.1.0 release
|
any chance you'll merge and cut a new release with this soon? |
|
hi @pariser, just wondering if there is a timeline on releasing these changes? thank you! |
|
Any updates on this? |
|
I do apologize for the long and frankly unnecessary delay in getting this over the finish line. I've just merged this branch and pushed the v4.0.0 gem to rubygems.org (link). FYI especially to @ericatripp @magshi @WozniakMac @blueberrystream @antrix1 @wilsonsilva @FabricioFFC @Lokideos @zpaines @aoc @khiav223577 -- commenters on this PR who have all been really patient and encouraging -- thank you all. |
|
Thank you!!! |
|
@pariser Thanks!!!! |
|
Thank you! Fantastic job! |
Start working on (long awaited) ruby3.0 support; as copied from the changelog: