Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Create browser specific styles for chrome and firefox #45889

Open
AleksanderBodurri opened this issue May 5, 2022 · 3 comments
Open

DevTools: Create browser specific styles for chrome and firefox #45889

AleksanderBodurri opened this issue May 5, 2022 · 3 comments
Assignees
@MariusTilvanDev
Labels
comp: devtools feature good first issue
Milestone
Backlog

Comments

@AleksanderBodurri
Copy link
Member

@AleksanderBodurri AleksanderBodurri commented May 5, 2022 •
edited

Description

Currently Angular DevTools is designed to mimic the styling of Chrome DevTools. Now that DevTools can be built for Firefox, we can style Angular DevTools with some browser specific styling to match the DevTools of the browser that it was built for.

Proposed solution

Let’s create some styles for each browser and then programmatically toggle them based on the browser environment. We can use https://material.angular.io/cdk/platform/overview to detect which browser we're running in.
@AleksanderBodurri AleksanderBodurri added good first issue comp: devtools labels May 5, 2022
@ngbot ngbot bot added this to the needsTriage milestone May 5, 2022
@ngbot ngbot bot added this to the needsTriage milestone May 5, 2022
@ngbot ngbot bot added this to the needsTriage milestone May 5, 2022
@AleksanderBodurri AleksanderBodurri added the feature label May 5, 2022
@ngbot ngbot bot removed this from the needsTriage milestone May 5, 2022
@ngbot ngbot bot added this to the Backlog milestone May 5, 2022
@MariusTilvanDev
Copy link
Contributor

@MariusTilvanDev MariusTilvanDev commented May 14, 2022

Hi, I would like to take this if it is available.

@MariusTilvanDev MariusTilvanDev mentioned this issue May 14, 2022
Closed
14 tasks
@AleksanderBodurri
Copy link
Member Author

@AleksanderBodurri AleksanderBodurri commented May 15, 2022

@MariusTilvanDev thank you for taking this issue! I've assigned it to you.

I see you have a PR open already. Let me know when it's ready for review 😄

@MariusTilvanDev
Copy link
Contributor

@MariusTilvanDev MariusTilvanDev commented May 15, 2022 •
edited

@AleksanderBodurri The PR is ready for review :)

MariusTilvanDev added a commit to MariusTilvanDev/angular that referenced this issue May 15, 2022
@MariusTilvanDev
feat(devtools): Create browser specific styles for chrome and firefox
d0bc429 
Create browser specific styles for chrome and firefox

partially fix angular#45889
@MariusTilvanDev MariusTilvanDev mentioned this issue May 18, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariusTilvanDev MariusTilvanDev

Labels
comp: devtools feature good first issue
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@AleksanderBodurri @MariusTilvanDev