Update docs #1357
Merged
Update docs #1357
+48
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-j-m
reviewed
May 12, 2022
|
|
||
| ```ruby | ||
| class UserComponent < ViewComponent::Base | ||
| include IconHelper |
There was a problem hiding this comment.
With this order flipping, you may want to define/introduce the IconHelper module in this section (as opposed to below in the helpers proxy recommendation).
There was a problem hiding this comment.
Oh, yes! Thanks for catching this
Co-authored-by: Kevin Murphy <murphy.kevin.mail@gmail.com>
dylanatsmith
reviewed
May 12, 2022
Spone
reviewed
May 12, 2022
docs/CHANGELOG.md
Outdated
|
|
||
| *Joel Hawksley* | ||
|
|
||
| * The ViewComponent team at GitHub is hiring! We're looking for a Rails engineer with accessibility experience: [https://boards.greenhouse.io/github/jobs/3802139]. Reach out to joelhawksley@github.com with any questions! |
There was a problem hiding this comment.
@joelhawksley The link seems broken.
There was a problem hiding this comment.
Looks like this is the active URL: https://boards.greenhouse.io/github/jobs/4020166
Spone
reviewed
May 12, 2022
Spone
reviewed
May 12, 2022
Co-authored-by: Dylan Smith <dylanatsmith@gmail.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
Spone
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR:
githubtemplate.