gh-92417: subprocess docs: remove note on compatibility with Python <3.5
#92538
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
reviewed
May 9, 2022
| @@ -33,9 +33,6 @@ The recommended approach to invoking subprocesses is to use the :func:`run` | |||
| function for all use cases it can handle. For more advanced use cases, the | |||
| underlying :class:`Popen` interface can be used directly. | |||
|
|
|||
| The :func:`run` function was added in Python 3.5; if you need to retain | |||
There was a problem hiding this comment.
We normally keep the notes. on when a function was added.
There are many packages that need to maintain cross-version support even if we don't support the old versions. This information is critical for them.
There was a problem hiding this comment.
The .. versionadded:: 3.5 note for subprocess.run(), on line 103 of this file, is not touched by this PR (and I would not want to remove it). This PR proposes to remove an additional note, which seems to me to be overly prominent now that 3.4 has been end-of-life for a long time.
serhiy-storchaka
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#92417