Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-47194: Update zlib to v1.2.12 on Windows to resolve CVE-2018-25032 (GH-32241) #32250

Merged
merged 1 commit into from May 16, 2022
Merged

[3.8] bpo-47194: Update zlib to v1.2.12 on Windows to resolve CVE-2018-25032 (GH-32241) #32250

merged 1 commit into from May 16, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 2, 2022 •
edited by bedevere-bot

(cherry picked from commit 6066739)

Co-authored-by: Zachary Ware zach@python.org

https://bugs.python.org/issue47194

@miss-islington miss-islington requested a review from as a code owner Apr 2, 2022
@bedevere-bot bedevere-bot mentioned this pull request Apr 2, 2022
Merged
@bedevere-bot bedevere-bot added the type-security label Apr 2, 2022
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Apr 2, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

zooba
zooba approved these changes Apr 2, 2022
View changes
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Apr 2, 2022

@zware and @zooba: Status check is done, and it's a failure ❌ .

@ned-deily ned-deily linked an issue Apr 11, 2022 that may be closed by this pull request
Upgrade to zlib v1.2.12 in CPython binary releases #91350
Closed
@gpshead gpshead mentioned this pull request Apr 10, 2022
Closed
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Apr 20, 2022

@zware and @zooba: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@vstinner
Copy link
Member

@vstinner vstinner commented May 6, 2022

The Docs CI job failed with:

Missing the required blurb or sphinx-build tools.
Please run 'make venv' to install local copies.

@zware @miss-islington
bpo-47194: Update zlib to v1.2.12 on Windows to resolve CVE-2018-25032 (
cfe0691 
pythonGH-32241)

(cherry picked from commit 6066739)

Co-authored-by: Zachary Ware <zach@python.org>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

2 similar comments
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

vstinner
vstinner approved these changes May 6, 2022
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM, good bot.

@ambv: Can you please merge this security fix? The fix already landed in the 3.7 branch.

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

@zware and @zooba: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 6, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

gpshead
gpshead approved these changes May 6, 2022
View changes
@zware zware requested a review from ambv May 12, 2022
@ambv ambv merged commit 7ccdec3 into python:3.8 May 16, 2022
13 checks passed
@miss-islington miss-islington deleted the backport-6066739-3.8 branch May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

@vstinner vstinner

@zooba zooba

@ambv ambv

Assignees

@ambv ambv

Labels
CLA signed OS-windows type-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to zlib v1.2.12 in CPython binary releases
8 participants
@miss-islington @vstinner @gpshead @zooba @ambv @the-knights-who-say-ni @bedevere-bot @zware