Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-92804: Fix memory leak in memoryview iterator #92805

Merged
merged 2 commits into from May 14, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 14, 2022

Closed #92804

fochoao
Copy link

@fochoao fochoao commented on 7d1b488 May 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this indeed...

@corona10 corona10 merged commit d923fdf into python:main May 14, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 14, 2022

Thanks @kumaraditya303 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 14, 2022
(cherry picked from commit d923fdf)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this issue May 14, 2022
(cherry picked from commit d923fdf)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 deleted the gh-92804 branch May 14, 2022
@vstinner
Copy link
Member

@vstinner vstinner commented May 16, 2022

Thanks @kumaraditya303 for the PR, and @corona10 for merging it tacotada.. I'm working now to backport this PR to: 3.11

IMO that's an enhancement, not a bugfix. I don't think that it's worth it to backport enhancements. (For this one, if it's already done, I don't care). For similar changes that I did in Python 3.10 and 3.11, I didn't backport these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants