Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91731: Fix typo in pymacro.h #92618

Merged
merged 2 commits into from May 10, 2022
Merged

gh-91731: Fix typo in pymacro.h #92618

merged 2 commits into from May 10, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 10, 2022

No description provided.

@pablogsal pablogsal mentioned this pull request May 10, 2022
Merged
@vstinner
Copy link
Member

vstinner commented May 10, 2022

You should use gh-91731: rather than skipping the issue. You can add it when you merge the PR.

It seems like macOS also has build error with static_assert() :-( #91731 (comment)

vstinner
vstinner reviewed May 10, 2022
View changes
Copy link
Member

@vstinner vstinner left a comment

Each time I saw the project name mentioned, it was written lower case.

Include/pymacro.h Outdated Show resolved Hide resolved
@pablogsal pablogsal changed the title Fix typo in pymacro.h gh-91731: Fix typo in pymacro.h May 10, 2022
@pablogsal
Copy link
Member Author

pablogsal commented May 10, 2022

ou should use gh-91731: rather than skipping the issue. You can add it when you merge the 

Done :)

@pablogsal
Copy link
Member Author

pablogsal commented May 10, 2022

It seems like macOS also has build error with static_assert() :-( #91731 (comment)

The never ending story :(

@pablogsal @vstinner
Update Include/pymacro.h
58642c8 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes May 10, 2022
View changes
Copy link
Member

@vstinner vstinner left a comment

Peeeerfect.

@pablogsal pablogsal merged commit 4e6da50 into python:main May 10, 2022
12 checks passed
@pablogsal pablogsal deleted the fix_typo branch May 10, 2022
@miss-islington
Copy link
Contributor

miss-islington commented May 10, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented May 10, 2022

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e6da502f42e3cbdffbe850833d2b04996232f0d 3.10

@miss-islington
Copy link
Contributor

miss-islington commented May 10, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 10, 2022

Sorry @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4e6da502f42e3cbdffbe850833d2b04996232f0d 3.11

@miss-islington
Copy link
Contributor

miss-islington commented May 10, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 10, 2022

GH-92623 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@pablogsal @miss-islington
pythongh-91731: Fix typo in pymacro.h (pythonGH-92618)
74c4893 
* Fix typo in pymacro.h

* Update Include/pymacro.h

Co-authored-by: Victor Stinner <vstinner@python.org>

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 4e6da50)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington @pablogsal
gh-91731: Fix typo in pymacro.h (GH-92618)
6546af3 
* Fix typo in pymacro.h

* Update Include/pymacro.h

Co-authored-by: Victor Stinner <vstinner@python.org>

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 4e6da50)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @vstinner @miss-islington @bedevere-bot