Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 623: Remove wstr from Unicode #92536

Open
methane opened this issue May 9, 2022 · 3 comments
Open

PEP 623: Remove wstr from Unicode #92536

methane opened this issue May 9, 2022 · 3 comments
Labels
type-feature

Comments

@methane
Copy link
Member

@methane methane commented May 9, 2022

Feature or enhancement

PEP 623
@methane methane added the type-feature label May 9, 2022
@methane methane mentioned this issue May 9, 2022
Merged
@vstinner
Copy link
Member

@vstinner vstinner commented May 11, 2022

FYI the lxml project still uses uses deprecated functions:

src/lxml/parser.pxi:            py_buffer_len = python.PyUnicode_GET_DATA_SIZE(utext)
src/lxml/parser.pxi:            c_len = python.PyUnicode_GET_DATA_SIZE(text)
src/lxml/python.pxd:    cdef Py_ssize_t PyUnicode_GET_DATA_SIZE(object ustring)

Compiler warnings on Python 3.11:

src/lxml/etree.c: In function ‘__pyx_f_4lxml_5etree_11_BaseParser__parseUnicodeDoc’:
src/lxml/etree.c:119132:5: warning: ‘PyUnicode_GET_DATA_SIZE’ is deprecated [-Wdeprecated-declarations]
119132 |     __pyx_v_py_buffer_len = PyUnicode_GET_DATA_SIZE(__pyx_v_utext);
       |     ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/python3.11/unicodeobject.h:1042,
                 from /usr/include/python3.11/Python.h:51,
                 from src/lxml/etree.c:99:
/usr/include/python3.11/cpython/unicodeobject.h:657:26: note: declared here
  657 | static inline Py_ssize_t PyUnicode_GET_DATA_SIZE(PyObject *op)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
src/lxml/etree.c:119141:5: warning: ‘PyUnicode_AS_DATA’ is deprecated [-Wdeprecated-declarations]
119141 |     __pyx_v_c_text = PyUnicode_AS_DATA(__pyx_v_utext);
       |     ^~~~~~~~~~~~~~
/usr/include/python3.11/cpython/unicodeobject.h:691:27: note: declared here
  691 | static inline const char* PyUnicode_AS_DATA(PyObject *op)
      |                           ^~~~~~~~~~~~~~~~~
src/lxml/etree.c: In function ‘__pyx_f_4lxml_5etree__parseDoc’:
src/lxml/etree.c:125721:7: warning: ‘PyUnicode_GET_DATA_SIZE’ is deprecated [-Wdeprecated-declarations]
125721 |       __pyx_v_c_len = PyUnicode_GET_DATA_SIZE(__pyx_v_text);
       |       ^~~~~~~~~~~~~
/usr/include/python3.11/cpython/unicodeobject.h:657:26: note: declared here
  657 | static inline Py_ssize_t PyUnicode_GET_DATA_SIZE(PyObject *op)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~

methane added a commit that referenced this issue May 12, 2022
@methane
gh-92536: PEP 623: Remove wstr and legacy APIs from Unicode (GH-92537)
f9c9354
@methane
Copy link
Member Author

@methane methane commented May 12, 2022

Thank you for reporting.
I reported it to lxml. https://bugs.launchpad.net/lxml/+bug/1973155

I tried to fix it but I don't have enough skill to write compile-time switch in Cython.
If it is difficult to fix it soon, I will resurrect PyUnicode_AS_DATA and PyUnicode_GET_DATA_SIZE as dummy function that just raise an exception.

@vstinner
Copy link
Member

@vstinner vstinner commented May 12, 2022

I tried to fix it but I don't have enough skill to write compile-time switch in Cython.

I wrote https://github.com/gevent/gevent/pull/1872/files which has conditional code depending on the Python version.

methane added a commit to methane/cpython that referenced this issue May 13, 2022
@methane
pythongh-92536: Doc update about Py_UNICODE removal
54e54b1
methane added a commit that referenced this issue May 13, 2022
@methane
gh-92536: Doc update about Py_UNICODE removal (GH-92756)
e371d5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @methane