gh-84461: Add --enable-wasm-pthreads and more file systems (GH-91820) #91820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Apr 22, 2022
tiran
changed the title
erlend-aasland
reviewed
Apr 23, 2022
Looks good! The WASM autoconf section is also much more readable now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Dynamic linking and pthreads are a field of landmines. The PR allows us to test dynamic linking without pthreads on Node. I also include additional file systems so we could use browser builds under Node. FS support increases the JS file by meager 20k before compression.