Demonstrate both usetex and non-usetex in demo_text_path.py. #23029
+50
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the text is rendered with different font size (although it is set the same). Of course not related to the example code, but maybe worth commenting on in the example? I think it is a step in the right direction, so feel free to self-merge once the linting is sorted out. |
oscargus
approved these changes
May 15, 2022
|
Let's defer the size problem to another time. |
timhoffm
approved these changes
May 15, 2022
IMHO there's still a lot room for improvement in this example, e.g.
- Structure: There are multiple things going on and it's hard to see which code part affects which part of the image.
- Clarity: The mentioned image clipping is hard to spot because it only uses two characters, each of which clips an area of largely constant color.
- Clutter: The Offsetbox/AnnotationBbox stuff adds a lot of code that is not related to the main objective of the example.
Anyway, It's an improvement to show both usetex cases explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).