Skip to content

FileUploader tests + types #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Mar 3, 2022
Merged

FileUploader tests + types #1417

merged 50 commits into from
Mar 3, 2022

Conversation

brandongregoryscott
Copy link
Contributor

Overview

Adds tests for utility functions + FileUploader and FileCard components (#1415). Additionally, ports over the TS definitions for consumer usage and adds some additional JSDoc commentary to internal functions

Screenshots (if applicable)

Documentation

  • Updated Typescript types and/or component PropTypes
  • [-] Added / modified component docs
  • [-] Added / modified Storybook stories

… from lodash, port over FileUploader without styling
Copy link
Contributor

@zkuzmic zkuzmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamebkj
Copy link
Contributor

kamebkj commented Mar 3, 2022

Love the tests!!

@brandongregoryscott brandongregoryscott merged commit 9cc59a2 into segmentio:file-uploader Mar 3, 2022
@brandongregoryscott brandongregoryscott deleted the file-uploader-tests-etc branch March 7, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants