Skip to content

Update Create a repository section #17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2022
Merged

Update Create a repository section #17835

merged 2 commits into from
Jun 3, 2022

Conversation

jatin837
Copy link
Contributor

@jatin837 jatin837 commented May 14, 2022 •
edited by skedwards88
Loading

backslash in JSON data is causing JSON parsing error

Why:

Closes #17836

What's being changed:

Check off the following:

  • [X ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jatin837
Update Create a repository section
781c7ba 
backslash in JSON data is causing JSON parsing error
@welcome
Copy link

welcome bot commented May 14, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
rest/guides/getting-started-with-the-rest-api.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@jatin837 jatin837 mentioned this pull request May 14, 2022
Closed
1 task
@steveward steveward added waiting for review Issue/PR is waiting for a writer's review ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team and removed triage Do not begin working on this issue until triaged by the team labels May 19, 2022
@steveward
Copy link
Member

Thanks @jatin837, I'll get this triaged for review. 👀

@skedwards88
Copy link
Contributor

skedwards88 commented Jun 2, 2022 •
edited
Loading

Thanks for raising this issue. The backslashes work for me, so I suspect that this is operating system related. Can you share your operating system? I misread your PR. Disregard this!

skedwards88
skedwards88 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jun 2, 2022
@cmwilson21 cmwilson21 merged commit c586382 into github:main Jun 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a repository section has wrong curl syntax
4 participants
@jatin837 @steveward @skedwards88 @cmwilson21