-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-87766: fix highlight location for f-string field errors #92856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per above
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
The Docs/Docs(pull_request) failed with "Run python Doc/tools/check-warnings.py EDIT: I did the above after hitting the Update button, which confused the situation. Will update again when button reappears. |
apparently fixed. I will recheck offsets
Yassir, thank you for contributing. As I explained on the issue, changes in 3.12 made the issue obsolete. So a new PR against 3.11 would be needed. However, when I copied the new code into a branch of 3.11, it did not fix the issue. Since this would benefit very few users, those who a) install the next (and I believe last) 3.11 release and b) make this mistake (which only I reported), I would rather spend my time fixing IDLE on issues that will benefit more users, now and in the future. Hence, closing. |
This is a fix for issue 87766