Skip to content

gh-87766: fix highlight location for f-string field errors #92856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

ukarroum
Copy link
Contributor

@ukarroum ukarroum commented May 16, 2022

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per above

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ukarroum
Copy link
Contributor Author

I have made the requested changes; please review again

@terryjreedy
Copy link
Member

terryjreedy commented Oct 24, 2023

The Docs/Docs(pull_request) failed with "Run python Doc/tools/check-warnings.py
python: can't open file '/home/runner/work/cpython/cpython/Doc/tools/check-warnings.py': [Errno 2] No such file or directory". This seems like a failure of the test bot. I am rerunning the failed test and if it fails again, will report it to other devs.

EDIT: I did the above after hitting the Update button, which confused the situation. Will update again when button reappears.

@terryjreedy terryjreedy dismissed hauntsaninja’s stale review October 24, 2023 14:46

apparently fixed. I will recheck offsets

@terryjreedy
Copy link
Member

Yassir, thank you for contributing. As I explained on the issue, changes in 3.12 made the issue obsolete. So a new PR against 3.11 would be needed. However, when I copied the new code into a branch of 3.11, it did not fix the issue. Since this would benefit very few users, those who a) install the next (and I believe last) 3.11 release and b) make this mistake (which only I reported), I would rather spend my time fixing IDLE on issues that will benefit more users, now and in the future. Hence, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants