Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92679: Clarify asyncio.loop.start_tls parameters #92682

Merged
merged 6 commits into from Nov 2, 2022
Merged

gh-92679: Clarify asyncio.loop.start_tls parameters #92682

merged 6 commits into from Nov 2, 2022

Conversation

arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented May 11, 2022 •
edited by bedevere-bot

@arhadthedev arhadthedev requested review from 1st1 and asvetlov as code owners May 11, 2022
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 11, 2022
@arhadthedev arhadthedev mentioned this pull request May 11, 2022
Closed
7 tasks
@kumaraditya303 kumaraditya303 self-requested a review May 11, 2022
@arhadthedev
Copy link
Contributor Author

arhadthedev commented Jul 26, 2022

@1st1 Could you review and possibly merge please?

@kumaraditya303 kumaraditya303 removed their request for review Jul 26, 2022
@arhadthedev
Copy link
Contributor Author

arhadthedev commented Jul 29, 2022

@1st1 Could you look at this and #92680 doc-only PRs please? (pinging because #95442 (review) was published a dozen of minutes ago).

@arhadthedev arhadthedev requested a review from gvanrossum as a code owner Sep 25, 2022
@gvanrossum gvanrossum merged commit 898d0d9 into python:main Nov 2, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 2, 2022

Thanks @arhadthedev for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 2, 2022

Sorry @arhadthedev and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 898d0d9ad8328326ba5f7df9952e9dc287766ca3 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@arhadthedev @miss-islington
pythongh-92679: Clarify asyncio.loop.start_tls parameters (pythonGH-9…
8d2f1c2 
…2682)

(cherry picked from commit 898d0d9)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-bot
Copy link

bedevere-bot commented Nov 2, 2022

GH-98990 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Nov 2, 2022

Thanks @arhadthedev for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@arhadthedev @miss-islington
pythongh-92679: Clarify asyncio.loop.start_tls parameters (pythonGH-9…
48db74e 
…2682)

(cherry picked from commit 898d0d9)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-bot
Copy link

bedevere-bot commented Nov 2, 2022

GH-98992 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @arhadthedev
gh-92679: Clarify asyncio.loop.start_tls parameters (GH-92682)
5f0d266 
(cherry picked from commit 898d0d9)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @arhadthedev
gh-92679: Clarify asyncio.loop.start_tls parameters (GH-92682)
46ccb35 
(cherry picked from commit 898d0d9)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@arhadthedev arhadthedev deleted the asyncio-start_tls-doc branch Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@1st1 1st1

@asvetlov asvetlov

Assignees

@gvanrossum gvanrossum

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arhadthedev @miss-islington @bedevere-bot @gvanrossum @kumaraditya303