Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-92780: Improve sqlite3.Connection.create_collation docs #92790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 13, 2022

Resolves #92780

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 13, 2022

@AdrianIssott, would you mind reviewing this?

@erlend-aasland erlend-aasland requested a review from AlexWaygood May 13, 2022
higher than the second. Note that this controls sorting (ORDER BY in SQL) so
your comparisons don't affect other SQL operations.
Copy link
Contributor Author

@erlend-aasland erlend-aasland May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this last sentence here is worth keeping. If the user is creating a collating function, one must assume they have more than a basic grasp of both SQL and SQLite. I'm inclined to removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants