Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35561: Fix valgrind warnings in selectmodule.c #18060

Merged

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jan 19, 2020

Update Misc/valgrind-python.supp to suppress the false alarm.

https://bugs.python.org/issue35561

Update Misc/valgrind-python.supp to suppress the false alarm.
@ZackerySpytz
Copy link
Contributor Author

@ZackerySpytz ZackerySpytz commented Jan 19, 2020

I don't think this needs a news entry.

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 19, 2020

I confirm that this PR fix https://bugs.python.org/issue35561

I tested manually that the warning goes away with my test: https://bugs.python.org/issue35561#msg359433

@vstinner vstinner merged commit d8ef644 into python:master Jan 19, 2020
5 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 19, 2020

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 19, 2020

Thanks @ZackerySpytz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 19, 2020
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 19, 2020

GH-18070 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 19, 2020
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 19, 2020

GH-18071 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this issue Jan 19, 2020
Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this issue Jan 19, 2020
Update Misc/valgrind-python.supp to suppress the false alarm.
(cherry picked from commit d8ef644)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Jan 31, 2020
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
opavlyuk pushed a commit to opavlyuk/cpython that referenced this issue Feb 12, 2020
…-18060)

Update Misc/valgrind-python.supp to suppress the false alarm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants