Skip to content

add empty-string validation for sqs user queue attributes #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2022
Merged

add empty-string validation for sqs user queue attributes #6090

merged 2 commits into from
May 19, 2022

Conversation

thrau
Copy link
Member

@thrau thrau commented May 18, 2022 •
edited
Loading

Fixes #6044

Also removed a duplicate test

@thrau thrau requested a review from baermat May 18, 2022 21:03
@thrau thrau temporarily deployed to localstack-ext-tests May 18, 2022 21:03 Inactive
@github-actions github-actions bot added size/s aws:sqs Amazon Simple Queue Service labels May 18, 2022
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 9m 58s ⏱️ + 10m 15s
1 034 tests ±0  1 006 ✔️ ±0  28 💤 ±0  0 ❌ ±0 
1 330 runs  ±0  1 275 ✔️ ±0  55 💤 ±0  0 ❌ ±0 

Results for commit d1a98a1. ± Comparison against base commit b296a99.

@thrau thrau merged commit e2ec88f into master May 19, 2022
@thrau thrau deleted the sqs-fixes branch May 19, 2022 09:53
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baermat baermat Awaiting requested review from baermat

Assignees
No one assigned
Labels
aws:sqs Amazon Simple Queue Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: SQS client crashes if malformed request
1 participant
@thrau