New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NestJS adapter #191
Comments
Hey @talentlessguy I see this issue is opened for quite some time. Also, I am wondering how would one test the underlying implementation of the mentioned adapter? |
@ognjenjevremovic you could either create the separate repo with your own rights and else, or create a pull request to test the implementation you can create an example in |
if anyone wants to work on that, I'll create a new repo for NestJS |
Hey, I'd love to give it a shot, but I'm kinda new to open source and was hoping for some guidance on how to do it? |
@KaviiSuri I'll create a new repo in the org and will assign you as a contributor does this sound good for you? |
Yeah, sounds good!! Also, I'm new to tinyhttp and beginner with nestjs, so could you give me some resources to get started too? |
@KaviiSuri there's tinyhttp documentation website regarding Nest, it's the same, I mean there is also docs and also see links above for specific info |
Okay, thanks, I'll get to it |
Hey, I'm going through the docs and code samples you refrenced As of now, it seems like I need to implement the Is that it? Is there something I've missed? |
@KaviiSuri no idea, I haven't ever used Nest :/ |
Hey man, I'm not home this week, I'll start working the adapter the coming week. Just wanted to keep you in the loop. |
Has there been any progress on the NestJS adapter @KaviiSuri? I am unable find the repo, @talentlessguy was it deleted or made private? |
Hey @talentlessguy even I couldn't see the repo so I thought I shouldn't continue.. |
@KaviiSuri made the package public https://github.com/tinyhttp/nest |
Thanks, will get started on this asap. |
Hey @talentlessguy , I started implementing the adapter and I need a little help. |
Why do you want to do that? |
@KaviiSuri HTTPS doesn't work in tests I think, it's a GitHub Actions issue |
@pSnehanshu i actually need to support a nestjs option that turns on https. @talentlessguy I actually don't need it tests, I just couldn't find how to do it with tinyhttp in an application too |
talentlessguy commentedNov 28, 2020
Is your feature request related to a problem? Please describe.
An adaper for Nest will let you use tinyhttp inside of Nest instead of Express.
Describe the solution you'd like
A Nest.js adapter package, something like
@tinyhttp/nest-adapter
Additional context
The text was updated successfully, but these errors were encountered: