Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45191: Fix tb_lineno for multi-line expressions #28753

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

@NaHCO314
Copy link

@NaHCO314 NaHCO314 commented Oct 6, 2021

https://bugs.python.org/issue45191

NaHCO314 added 6 commits Oct 5, 2021
Merge remote-tracking branch 'upstream/main' into fix-issue-45191
bpo-45191: Fix tb_lineno for multi-line expressions
Merge remote-tracking branch 'upstream/main' into fix-issue-45191
aaa
Merge remote-tracking branch 'upstream/main' into fix-issue-45191
aaa
@NaHCO314
Copy link
Author

@NaHCO314 NaHCO314 commented Oct 19, 2021

I think I made a mistake in the commit message, should I fix it?
Also, I have a commit history that I don't need, can it be merged together?

Loading

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 23, 2021

I think I made a mistake in the commit message, should I fix it?
Also, I have a commit history that I don't need, can it be merged together?

Both can be changed when/if we merge, so don't worry too much about it :)

Loading

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 23, 2021

You need to rebase though, as you have conflicts in test_dis

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants