gh-92734: Add indentation feature to reprlib.Repr #92735
+82
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an indentation feature to the reprlib.Repr class. This includes the actual implementation as well as added tests and an attribute description for the docs.
Ovsyanka83
suggested changes
May 14, 2022
I haven't found any issues with the code or the tests. The docs are my only concern.
| @@ -123,6 +123,16 @@ which format specific object types. | |||
| similar manner as :attr:`maxstring`. The default is ``20``. | |||
|
|
|||
|
|
|||
| .. attribute:: Repr.indent | |||
|
|
|||
| If this attribute is set to ``None`` (default), no indentation of the output | |||
There was a problem hiding this comment.
These docs are a little confusing and have to be read multiple times to understand, even though the API itself is more or less intuitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#92734