Add notes maintaining ABCs #92736
Merged
Add notes maintaining ABCs #92736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
May 12, 2022
Lib/_collections_abc.py
Outdated
| # Though irritating, the correct procedure for adding new abstract or | ||
| # mixin methods is to create a new class as a subclass of the previous | ||
| # class. For example, union(), intersection(), and difference() cannot |
There was a problem hiding this comment.
I'd replace "class" with "ABC" in both occurrences in this sentence, assuming that's what you meant.
| # | ||
| # Though classes that inherit from an ABC would automatically receive a | ||
| # new mixin method, registered classes would become non-compliant and | ||
| # violate the contract promised by ``isinstance(someobj, SomeABC)``. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We have a recurring issue where new maintainers aspire to modify the ABCs without understanding the implications. Adding some notes for the ABC maintenance facts-of-life.