Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when using interpolation instead of JS expression for slot names #9038

Open
revolter opened this issue Nov 7, 2018 · 4 comments · May be fixed by #9050
Open

Throw error when using interpolation instead of JS expression for slot names #9038

revolter opened this issue Nov 7, 2018 · 4 comments · May be fixed by #9050
Labels
feature request good first issue has PR

Comments

@revolter
Copy link

@revolter revolter commented Nov 7, 2018

What problem does this feature solve?

For this demo:

https://jsfiddle.net/2os9jken/

opening the console and running it throws the Interpolation inside attributes has been removed. Use v-bind or the colon shorthand instead. error for the span, but it should also throw it for the slot, as it has the exact same issue for its name attribute.

What does the proposed API look like?

N/A
@posva
Copy link
Member

@posva posva commented Nov 7, 2018

Thanks for the proposal, the warning was meant for people coming from v1 where this was allowed. Personally, I don't think it is worth adding any more warnings regarding this as it will rarely help any user

@revolter
Copy link
Author

@revolter revolter commented Nov 7, 2018

Well, old references still exist, and it's not that obvious for new users. It surely confused me in #9037.

kamilchlebek added a commit to kamilchlebek/vue that referenced this issue Nov 10, 2018
@kamilchlebek
feat(parser): throw error when using interpolation instead of JS expr…
c7f21bb 
…ession for slot names (vuejs#9038)
@kamilchlebek kamilchlebek linked a pull request Nov 10, 2018 that will close this issue
Open
13 tasks
@posva posva added the has PR label Nov 10, 2018
zleight1 added a commit to zleight1/vue that referenced this issue Dec 4, 2018
@zleight1
fix(parser): Fix for slot "name" property using interpolation as well…
a248607 
… as the "slot" property. (vuejs#9038)
@zleight1 zleight1 mentioned this issue Dec 4, 2018
Open
13 tasks
@prabhatmishra33
Copy link

@prabhatmishra33 prabhatmishra33 commented Oct 5, 2021 •
edited

Hello ! Is this issue fixed or yet open to be worked on ?

@prathameshpcodes
Copy link

@prathameshpcodes prathameshpcodes commented Feb 26, 2022

Is this issue fixed or yet to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(parser): throw error when using interpolation instead of expresssion (#9038) kamilchlebek/vue
4 participants
@posva @revolter @prabhatmishra33 @prathameshpcodes