Make SignalR Redis test thread-safe #41564

BrennanConroy · 2022-05-06T22:57:27Z

TestServer could shut down right after the first handler in

foreach (var (_, handler) in handlers)
{
    handler(channel, message);
}

is invoked, which creates a race with the second iteration of the loop checking for another item in the list while the list is cleared by the TestServer closing.

Make SignalR Redis test thread-safe

7336f4d

BrennanConroy added the area-signalr label May 6, 2022

BrennanConroy requested a review from halter73 as a code owner May 6, 2022

dotnet / aspnetcore Public

Make SignalR Redis test thread-safe #41564

Make SignalR Redis test thread-safe #41564

BrennanConroy commented May 6, 2022

dotnet / aspnetcore Public

Make SignalR Redis test thread-safe #41564

Are you sure you want to change the base?

Make SignalR Redis test thread-safe #41564

Conversation

BrennanConroy commented May 6, 2022