Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92817: Fix precedence of options to py.exe launcher #92988

Merged
merged 3 commits into from May 19, 2022
Merged

gh-92817: Fix precedence of options to py.exe launcher #92988

merged 3 commits into from May 19, 2022

Conversation

zooba
Copy link
Member

@zooba zooba commented May 19, 2022

Fixes #92817

@zooba zooba requested a review from a team as a code owner May 19, 2022
@zooba zooba merged commit 73473fd into python:main May 19, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 19, 2022

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh-92817 branch May 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@zooba @miss-islington
pythongh-92817: Fix precedence of options to py.exe launcher (pythonG…
499d625 
…H-92988)

(cherry picked from commit 73473fd)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented May 19, 2022

GH-92993 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request May 19, 2022
@miss-islington @zooba
gh-92817: Fix precedence of options to py.exe launcher (GH-92988)
a2ec09b 
(cherry picked from commit 73473fd)

Co-authored-by: Steve Dower <steve.dower@python.org>
@vstinner
Copy link
Member

vstinner commented May 20, 2022

test_launcher fails on the ARM64 Windows Non-Debug Azure 3.x buildbot. The issue maybe be caused by this change, see: #93005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Launcher for Windows (py.exe) seems to ignore virtual environment in recent beta 3.11.0b1
4 participants
@zooba @miss-islington @bedevere-bot @vstinner