[java] Include JMX monitoring feature in the Grid local distributor #10674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## trunk #10674 +/- ##
==========================================
+ Coverage 45.58% 45.60% +0.01%
==========================================
Files 86 86
Lines 5739 5741 +2
Branches 274 274
==========================================
+ Hits 2616 2618 +2
Misses 2849 2849
Partials 274 274
Continue to review full report at Codecov.
|
This patch exposes the number of nodes in the local distributor using JMX through a managed atribute called NodeCount. Issue SeleniumHQ#9794
…s in local distributor Issue SeleniumHQ#9794
|
SonarCloud Quality Gate failed. |
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…eleniumHQ#10674) * [java] Set LocalDistributor as ManagedService This patch exposes the number of nodes in the local distributor using JMX through a managed atribute called NodeCount. Issue SeleniumHQ#9794 * [java] Include metric for counting the number of down nodes in local distributor * [java] Include metric for counting the number of active and idle slots in local distributor Issue SeleniumHQ#9794 [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements issue #9794. It exposes metrics through JMX in the local distributor, namely:
Regarding the session elapsed time (requested in the original feature proposal issue), that info should be available using GraphQL.
Motivation and Context
Grid 4 already implements JMX monitoring on the nodes. This PR allows to gather also other metrics in the local distributor.
Types of changes
Checklist