Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake dependency causing failures on Windows Builds #74955

Closed
zengk95 opened this issue Mar 30, 2022 · 1 comment
Closed

cmake dependency causing failures on Windows Builds #74955

zengk95 opened this issue Mar 30, 2022 · 1 comment
Labels
ci: sev triaged

Comments

@zengk95
Copy link
Contributor

@zengk95 zengk95 commented Mar 30, 2022

NOTE: Remember to label this issue with "ci: sev"

Current Status

Root cause has been determined and currently trying to land fix in #74954

Error looks like

-- Configuring done
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_CUDA_COMPILE_WHOLE_COMPILATION
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.

Incident timeline (all times pacific)

Click for example
  • 3/29 10PM CST First error on HUD
  • 3/30 6AM CST First alert fired
  • 3/30 8AM CST Responded and started debugging
  • 3/30 9:15 CST Found issue and attempting to fix

User impact

Pytorch users have broken windows builds

Root cause

Cmake dependency updated and didn't set an internal variable we needed.

Mitigation

Pinning the Cmake version

Prevention/followups

  • Pin more things
  • Retry with older versions?
@zengk95 zengk95 added the ci: sev label Mar 30, 2022
@zengk95 zengk95 closed this as completed Mar 30, 2022
@malfet malfet mentioned this issue Mar 30, 2022
Open
@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Apr 12, 2022

Update: Nikita--this is a cmake bug (conda yanked it afterwards). We should just unpin it, make sure it works and then be done with this. (I will add this to Dev Infra Backlog to discuss next sprint.)

@janeyx99 janeyx99 mentioned this issue Apr 12, 2022
Open
@janeyx99 janeyx99 added the triaged label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci: sev triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janeyx99 @zengk95